nyx, branch 2.1.0

Nyx release 2.1.0

2019-01-12T23:06:37+00:00

Drop website's frontpage note of our old name

2019-01-12T22:13:48+00:00

We renamed ourselves well over a year ago. Past due we stopped noting our old
name on the frontpage.

Fix python 3.x test regression

2019-01-12T21:58:50+00:00

Oops, my recent change to skip the installation test when offline broke
python3...

  ======================================================================
  ERROR: installation (unittest.loader._FailedTest)
  ----------------------------------------------------------------------
  ImportError: Failed to import test module: installation
  Traceback (most recent call last):
    File "/usr/lib/python3.5/unittest/loader.py", line 428, in _find_test_path
      module = self._get_module_from_name(name)
    File "/usr/lib/python3.5/unittest/loader.py", line 369, in _get_module_from_name
      __import__(name)
    File "/home/atagar/Desktop/nyx/test/installation.py", line 6, in 
      import urllib2
  ImportError: No module named 'urllib2'

Deduplicate common notice logs

2019-01-12T21:40:23+00:00

Just deduplicating a few notice runlevel messages hat pop up a lot on my relay.

Drop dependency on distutils

2019-01-11T19:18:40+00:00

Python 3.x no longer includes distutils by default...

  https://trac.torproject.org/projects/tor/ticket/26099

This is perfectly fine. We only used it to check if pip
or apt-get was installed. We should be using stem for
this anyway. I already dropped our dependency on distutils
in stem for this reason...

  https://gitweb.torproject.org/stem.git/commit/?id=9fa85ec

Avoid double counting connections

2019-01-11T18:45:05+00:00

When a guard, bridge, or exit we scrub sensitive connection data but also
aggregate it into graphs that present the client locales we're being used
from or exit ports.

In reviewing this for an old ticket [1] realized we're counting each
connection made with us rather than unique clients or exit usage. As
such, limiting our counts to one per a remote address.

[1] https://trac.torproject.org/projects/tor/ticket/4281

Skip installation test when offline

2019-01-10T22:58:46+00:00

On my morning bus commute I was pretty puzzled why our tests broke. Turns out
we fail in a rather confusing way that says our PYTHONPATH is misconfigured
when unable to install stem from pypi.

Fix interpreter panel unit tests

2019-01-10T19:19:47+00:00

Oops, line wrapping broke our tests...

  ======================================================================
  FAIL: test_multiline_panel (panel.interpreter.TestInterpreter)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/home/atagar/Desktop/nyx/test/__init__.py", line 59, in wrapped
      return func(self, *args, **kwargs)
    File "/usr/local/lib/python2.7/dist-packages/mock/mock.py", line 1305, in patched
      return func(*args, **keywargs)
    File "/home/atagar/Desktop/nyx/test/panel/interpreter.py", line 107, in test_multiline_panel
      self.assertEqual(EXPECTED_MULTILINE_PANEL, test.render(panel._draw).content)
  AssertionError: 'Control Interpreter:\n>>> GETINFO version\n250-version=0.2.4.27 (git-412e3f7dc9c6c01a)\n>>> to use this panel press enter' != u'Control Interpreter:\n>>> to use this panel press enter'

  ======================================================================
  FAIL: test_scrollbar (panel.interpreter.TestInterpreter)
  ----------------------------------------------------------------------
  Traceback (most recent call last):
    File "/home/atagar/Desktop/nyx/test/__init__.py", line 59, in wrapped
      return func(self, *args, **kwargs)
    File "/usr/local/lib/python2.7/dist-packages/mock/mock.py", line 1305, in patched
      return func(*args, **keywargs)
    File "/home/atagar/Desktop/nyx/test/panel/interpreter.py", line 120, in test_scrollbar
      self.assertEqual(EXPECTED_WITH_SCROLLBAR, test.render(panel._draw).content)
  AssertionError: 'Control Interpreter:\n |>>> GETINFO version\n |250-version=0.2.4.27 (git-412e3f7dc9c6c01a)\n |\n |\n |\n |\n |\n |\n |\n |\n |\n |\n |\n |\n |\n |\n |\n |\n |\n |\n |\n |\n |\n-+' != u'Control Interpreter:\n>>> to use this panel press enter'

  ----------------------------------------------------------------------

With commit 75052e8 tests should no longer directly modify their private
'_lines' attribute. We need to call the _add_line() helper instead to ensure
the wrapped and unwrapped attributes stay in sync.

Drop bold tag from changelog tickets

2019-01-09T19:38:29+00:00

I've been inconsistent on if tickets are wrapped with a bold tag or not.
Cursory glance indicates links are already a bold typeface so the presence
or omission of these tags don't look any different.

Implement delete key

2019-01-09T19:35:00+00:00

Special keys (arrows, home/end, etc) require for us to implement their
handling. Doing so for the delete key.

  https://trac.torproject.org/projects/tor/ticket/5835