From 76a5e0e89cd2fdc2b74ff6aa4813ccdc5de54065 Mon Sep 17 00:00:00 2001 From: teor Date: Mon, 13 Mar 2017 23:01:26 +1100 Subject: [PATCH] Bug 21723: Fix inconsistent generation of MOZ_MACBUNDLE_ID CFBundleIdentifiers can only contain [A-Za-z.-], and by convention the app component is lowercase and does not contain '.'. Make configure delete all characters other than [a-z-] when generating MOZ_MACBUNDLE_ID from MOZ_APP_DISPLAYNAME. (This affects "Tor Browser", but not "Firefox".) --- old-configure.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/old-configure.in b/old-configure.in index 8bb7819509275..9c39e9a53cfd9 100644 --- a/old-configure.in +++ b/old-configure.in @@ -5392,7 +5392,7 @@ fi AC_SUBST(MOZ_MACBUNDLE_NAME) dnl Mac bundle identifier (based on MOZ_APP_DISPLAYNAME) -MOZ_MACBUNDLE_ID=`echo $MOZ_APP_DISPLAYNAME | tr '[A-Z]' '[a-z]'` +MOZ_MACBUNDLE_ID=`echo $MOZ_APP_DISPLAYNAME | tr 'A-Z' 'a-z' | tr -dc 'a-z-'` MOZ_MACBUNDLE_ID=${MOZ_DISTRIBUTION_ID}.${MOZ_MACBUNDLE_ID} if test "$MOZ_DEBUG"; then MOZ_MACBUNDLE_ID=${MOZ_MACBUNDLE_ID}debug -- GitLab