From 7e8831e530de2b9269e41fa9b58597e07190e281 Mon Sep 17 00:00:00 2001 From: Mike Perry Date: Tue, 10 Sep 2013 18:14:40 -0700 Subject: [PATCH] Bug 8312: Remove "This plugin is disabled" barrier. We do not want to encourage our users to enable plugins at this point. The barrier also causes bad UX for HTML5 video fallback on YouTube. --- browser/modules/PluginContent.jsm | 7 ++++--- toolkit/pluginproblem/content/pluginProblem.xml | 2 +- 2 files changed, 5 insertions(+), 4 deletions(-) diff --git a/browser/modules/PluginContent.jsm b/browser/modules/PluginContent.jsm index 1bbfa9a505b70..ae01681982a18 100644 --- a/browser/modules/PluginContent.jsm +++ b/browser/modules/PluginContent.jsm @@ -526,9 +526,10 @@ PluginContent.prototype = { break; case "PluginDisabled": - let manageLink = this.getPluginUI(plugin, "managePluginsLink"); - this.addLinkClickCallback(manageLink, "forwardCallback", "managePlugins"); - shouldShowNotification = true; + // Screw the disabled message. It messes with HTML5 fallback on YouTube + let plugin_overlay = doc.getAnonymousElementByAttribute(plugin, "class", "mainBox"); + if (plugin_overlay != null) + plugin_overlay.style.visibility = "hidden"; break; case "PluginInstantiated": diff --git a/toolkit/pluginproblem/content/pluginProblem.xml b/toolkit/pluginproblem/content/pluginProblem.xml index d890be9006a47..cc2aefcc4311e 100644 --- a/toolkit/pluginproblem/content/pluginProblem.xml +++ b/toolkit/pluginproblem/content/pluginProblem.xml @@ -38,7 +38,7 @@ &reloadPlugin.pre;&reloadPlugin.middle;&reloadPlugin.post; - &managePlugins; +