user/atagar/exitmap, branch master Damian's exitmap repository Taking advantage of stem's new stem.util.test_tools 2014-02-13T17:37:46+00:00 Damian Johnson atagar@torproject.org 2014-02-13T17:37:46+00:00 d38ade4811cd0288f671fd53e7dac5328e04a3eb Clearing out a big chunk of code we copied from stem now that it's available in its utils. 
Clearing out a big chunk of code we copied from stem now that it's available in
its utils.
Invoking subcommands via a daemon thread 2014-02-02T21:55:23+00:00 Damian Johnson atagar@torproject.org 2014-02-02T21:55:23+00:00 3fe04ef471f1d0763a807930b21bf11d6e03b6bc Another thread without the daemon flag set. Also some minor non-functional tweaks. 
Another thread without the daemon flag set. Also some minor non-functional
tweaks.
Prompting tester to install pyflakes or pep8 if unavailailable 2014-02-02T21:53:52+00:00 Damian Johnson atagar@torproject.org 2014-02-02T21:50:23+00:00 8973bf95b535e394c0c820d88aabd844b9f578a1 On reflection we shouldn't just silently pass if pyflakes and pep8 are unavailable. We should notify the user that we didn't do anything instead. 
On reflection we shouldn't just silently pass if pyflakes and pep8 are
unavailable. We should notify the user that we didn't do anything instead.
Rewriting get_exits() 2014-02-02T21:53:44+00:00 Damian Johnson atagar@torproject.org 2014-02-02T21:44:40+00:00 2079df41972025231e1e03a74450fb591318206a This function is essentially doing a series of filters so simply opting for that instead. The only functional change is that we now only do the can_exit_to() filter if we have some hosts. From my read the prior code would reject everything instead which I suspect was a bug. 
This function is essentially doing a series of filters so simply opting for
that instead. The only functional change is that we now only do the
can_exit_to() filter if we have some hosts. From my read the prior code would
reject everything instead which I suspect was a bug.
Running queue_reader in a daemon thread 2014-02-02T21:27:41+00:00 Damian Johnson atagar@torproject.org 2014-02-02T21:27:41+00:00 48b0fa8e99ece0303bfafc844be011a48ba120e1 There's no reason for this to be a non-daemon thread. Especially since we aren't joining on it for shutdown. 
There's no reason for this to be a non-daemon thread. Especially since we
aren't joining on it for shutdown.
Simplifying exitselector conditionals 2014-02-02T21:15:05+00:00 Damian Johnson atagar@torproject.org 2014-02-02T21:15:05+00:00 03657ece06e39e070e12f68ce0ffef3bfeb327dd It's been too long since my CS courses. This conditionals made my head hurt... not ((address and address in desc.address) or (not address)) ... is equal to... (not (address and address in desc.address)) and address ... which in turn is equal to... (not address or address not in desc.address) and address The initial 'not address' is obviously pointless so this can finally be distilled to the far more intuitive... address and address not in desc.address The desc.address is a string. There's no reason to do substring comparison here so swapping to equality... address and address != desc.address I was tempted to just jump to that since it was clearly what the code was going for, but that initial consitional was so weird I wanted to prove to myself it was the same. :) 
It's been too long since my CS courses. This conditionals made my head hurt...

  not ((address and address in desc.address) or (not address))

... is equal to...

  (not (address and address in desc.address)) and address

... which in turn is equal to...

  (not address or address not in desc.address) and address

The initial 'not address' is obviously pointless so this can finally be
distilled to the far more intuitive...

  address and address not in desc.address

The desc.address is a string. There's no reason to do substring comparison here
so swapping to equality...

  address and address != desc.address

I was tempted to just jump to that since it was clearly what the code was going
for, but that initial consitional was so weird I wanted to prove to myself it
was the same. :)
Authenticate to tor via cookie auth 2014-02-02T20:59:19+00:00 Damian Johnson atagar@torproject.org 2014-02-02T03:33:27+00:00 fdbb1722d4ae02554f29436c8ae33adda6e3249b No reason not to include authentication. Stem can transparently handle anything except for password authentication. 
No reason not to include authentication. Stem can transparently handle anything
except for password authentication.
Static tests and shifting to PEP8 conventions 2014-02-02T01:07:36+00:00 Damian Johnson atagar@torproject.org 2014-02-02T01:07:28+00:00 57e0be340d91d47b7b82ec214bb3107d8141616b Adding a run_tests.py executable that runs pyflakes and pep8 checks on our project. Also shifting exitmap's conventions to be PEP8 compliant. None of these changes should have a functional impact, and indeed a quick sanity test of exitmap still works. 
Adding a run_tests.py executable that runs pyflakes and pep8 checks on our
project. Also shifting exitmap's conventions to be PEP8 compliant.

None of these changes should have a functional impact, and indeed a quick
sanity test of exitmap still works.
Renaming variables and functions to the underscore convention 2014-02-02T01:06:57+00:00 Damian Johnson atagar@torproject.org 2014-02-02T01:03:38+00:00 59db48de6853afb1e7789f52ec54203a5d181c06 Python's conventions are to use camelcase for classes (MyClass) but underscore for everything else (my_function() and my_variable). Actually, just a little while ago I spent over a week fixing this for arm (I was originally a java developer, so camelcase was an old habbit). Thankfully exitmap is a *lot* smaller. Did bulk renaming with... grep -ilr 'oldName' ./* | xargs -i@ sed -i 's/oldName/new_name/g' @ 
Python's conventions are to use camelcase for classes (MyClass) but underscore
for everything else (my_function() and my_variable). Actually, just a little
while ago I spent over a week fixing this for arm (I was originally a java
developer, so camelcase was an old habbit). Thankfully exitmap is a *lot*
smaller.

Did bulk renaming with...

  grep -ilr 'oldName' ./* | xargs -i@ sed -i 's/oldName/new_name/g' @
Removing spaces from around keywords and variables 2014-02-02T00:27:25+00:00 Damian Johnson atagar@torproject.org 2014-02-02T00:23:24+00:00 727940ebe3a3f16e1e83b2172333319b6464ad0f Yet another bit of PEP8 that exitmap follows but I don't. Removing E251 from the blacklist and fixing the occurances. 
Yet another bit of PEP8 that exitmap follows but I don't. Removing E251 from
the blacklist and fixing the occurances.