user/atagar/nyx, branch master

Rewrite port count dialog

2015-07-02T16:57:13+00:00

Revising the dialog that shows aggregated counts for entry or exit connections
(locales if a guard, or port usage if an exit). This is a pretty small popup
and code got even smaller with the cleanup, so moving it into popups.py.

Menus caused stacktrace when you pressed 'm'

2015-06-27T23:06:24+00:00

Issue spotted by Steven. Revisions to popup handling broke the menu...

  Traceback (most recent call last):
    File "./run_nyx", line 8, in 
      nyx.main()
    File "/home/atagar/Desktop/nyx/nyx/__init__.py", line 30, in main
      nyx.starter.main()
    File "/home/atagar/Desktop/nyx/stem/util/conf.py", line 288, in wrapped
      return func(*args, config = config, **kwargs)
    File "/home/atagar/Desktop/nyx/nyx/starter.py", line 91, in main
      curses.wrapper(nyx.controller.start_nyx)
    File "/usr/lib/python2.7/curses/wrapper.py", line 43, in wrapper
      return func(stdscr, *args, **kwds)
    File "/home/atagar/Desktop/nyx/nyx/controller.py", line 594, in start_nyx
      nyx.menu.menu.show_menu()
    File "/home/atagar/Desktop/nyx/nyx/menu/menu.py", line 119, in show_menu
      _draw_submenu(cursor, 1, 1, selection_left)
    File "/home/atagar/Desktop/nyx/nyx/menu/menu.py", line 159, in _draw_submenu
      popup, _, _ = nyx.popups.init(len(submenu.get_children()), menu_width, top, left, below_static = False)
  AttributeError: 'module' object has no attribute 'init'

Rewrite descriptor dialog

2015-06-27T21:18:56+00:00

Replacing the connection panel's descriptor dialog (the subwindow you see when
pressing 'd'). Only functional change is that it now includes microdescriptor
information (whereas before it only had consensus and server descriptors).

Separate panel from descriptor dialog

2015-06-27T21:16:28+00:00

Abstracting the connection panel from the function for showing a descriptor
dialog. This essentially moves the outer loop which handled connection panel
navigation where it belongs.

Rewrite descriptor dialog's draw() method

2015-06-27T19:31:00+00:00

Not quite done with the dialog, but damn its draw method is now better. :P

Revise size calculation for the descriptor dialog

2015-06-21T18:31:15+00:00

Tidying up this helper. The way we accounted for the size of line wraps didn't
look right since it didn't account for additional content (line number,
framing) on the line we wrapped onto.

This still isn't quite right since it doesn't account for word breaks but
*shrug*, probably good enough in practice.

Potential stacktrace when shutting down

2015-06-21T18:13:13+00:00

Our connection panel was missing a default value, causing exceptions to
possibly be uncaught...

  Traceback (most recent call last):
  File "/usr/lib/python2.7/threading.py", line 551, in __bootstrap_inner
    self.run()
  File "/home/atagar/Desktop/nyx/nyx/connections/conn_panel.py", line 352, in run
    self._update()
  File "/home/atagar/Desktop/nyx/nyx/connections/conn_panel.py", line 508, in _update
    for circ in tor_controller().get_circuits():
  File "/home/atagar/Desktop/nyx/stem/control.py", line 411, in wrapped
    return func(self, *args, **kwargs)
  File "/home/atagar/Desktop/nyx/stem/control.py", line 3050, in get_circuits
    response = self.get_info('circuit-status')
  File "/home/atagar/Desktop/nyx/stem/control.py", line 558, in msg
    self._socket.send(message)
  File "/home/atagar/Desktop/nyx/stem/socket.py", line 122, in send
    raise stem.SocketClosed()

Show microdescriptors in the descriptor popup

2015-06-21T17:29:06+00:00

Our popup that shows relay descriptors only supported server descriptors and
the consensus since it predated microdescriptors. Including those if it's
available.

Errors when rendering connection panel entry

2015-06-11T16:58:32+00:00

Stacktraces related to how we handle curses attributes on the connection
panel. This arose if you tried to view the panel when there was... well,
anything on it (usually if you disable DisableDebuggerAttachment).

  Traceback (most recent call last):
    File "./run_nyx", line 8, in 
      nyx.main()
    File "/home/atagar/Desktop/nyx/nyx/__init__.py", line 30, in main
      nyx.starter.main()
    File "/home/atagar/Desktop/nyx/stem/util/conf.py", line 288, in wrapped
      return func(*args, config = config, **kwargs)
    File "/home/atagar/Desktop/nyx/nyx/starter.py", line 91, in main
      curses.wrapper(nyx.controller.start_nyx)
    File "/usr/lib/python2.7/curses/wrapper.py", line 43, in wrapper
      return func(stdscr, *args, **kwds)
    File "/home/atagar/Desktop/nyx/nyx/controller.py", line 576, in start_nyx
      control.redraw(False)
    File "/home/atagar/Desktop/nyx/nyx/controller.py", line 402, in redraw
      panel_impl.redraw(force)
    File "/home/atagar/Desktop/nyx/nyx/util/panel.py", line 433, in redraw
      self.draw(self.max_x, self.max_y)
    File "/home/atagar/Desktop/nyx/nyx/connections/conn_panel.py", line 464, in draw
      attr |= extra_format
  TypeError: unsupported operand type(s) for |=: 'str' and 'int'

  Traceback (most recent call last):
    File "./run_nyx", line 8, in 
      nyx.main()
    File "/home/atagar/Desktop/nyx/nyx/__init__.py", line 30, in main
      nyx.starter.main()
    File "/home/atagar/Desktop/nyx/stem/util/conf.py", line 288, in wrapped
      return func(*args, config = config, **kwargs)
    File "/home/atagar/Desktop/nyx/nyx/starter.py", line 91, in main
      curses.wrapper(nyx.controller.start_nyx)
    File "/usr/lib/python2.7/curses/wrapper.py", line 43, in wrapper
      return func(stdscr, *args, **kwds)
    File "/home/atagar/Desktop/nyx/nyx/controller.py", line 576, in start_nyx
      control.redraw(False)
    File "/home/atagar/Desktop/nyx/nyx/controller.py", line 402, in redraw
      panel_impl.redraw(force)
    File "/home/atagar/Desktop/nyx/nyx/util/panel.py", line 433, in redraw
      self.draw(self.max_x, self.max_y)
    File "/home/atagar/Desktop/nyx/nyx/connections/conn_panel.py", line 463, in draw
      for msg, attr in draw_entry:
  ValueError: too many values to unpack

Stacktrace when showing connection panel's count dialog

2015-06-11T16:58:32+00:00

Simple error when pressing 'c' on the connection panel...

  Traceback (most recent call last):
    File "./run_nyx", line 8, in 
      nyx.main()
    File "/home/atagar/Desktop/nyx/nyx/__init__.py", line 30, in main
      nyx.starter.main()
    File "/home/atagar/Desktop/nyx/stem/util/conf.py", line 288, in wrapped
      return func(*args, config = config, **kwargs)
    File "/home/atagar/Desktop/nyx/nyx/starter.py", line 91, in main
      curses.wrapper(nyx.controller.start_nyx)
    File "/usr/lib/python2.7/curses/wrapper.py", line 43, in wrapper
      return func(stdscr, *args, **kwds)
    File "/home/atagar/Desktop/nyx/nyx/controller.py", line 625, in start_nyx
      is_keystroke_consumed = panel_impl.handle_key(key)
    File "/home/atagar/Desktop/nyx/nyx/connections/conn_panel.py", line 316, in handle_key
      elif key.match('c') and self.is_clients_allowed():
    File "/home/atagar/Desktop/nyx/nyx/connections/conn_panel.py", line 218, in is_clients_allowed
      my_fingerprint = self.get_info('fingerprint', None)
  AttributeError: 'ConnectionPanel' object has no attribute 'get_info'