user/gsathya/stem, branch master gsathya's stem repository Accounting for NULL access by ctypes 2013-02-18T02:09:58+00:00 Damian Johnson atagar@torproject.org 2013-02-18T02:09:58+00:00 08529723708ed514f6f5e2489d3c1be8c0e9ae36 Evidently accessing argc can raise a ValueError... https://trac.torproject.org/8266 
Evidently accessing argc can raise a ValueError...

https://trac.torproject.org/8266
Providing a string when str() is called on descriptors 2013-02-17T21:57:15+00:00 Damian Johnson atagar@torproject.org 2013-02-17T21:57:15+00:00 1a099106c43e37bf41f5c1f803f27cd2aad270f5 Python 2.x gets pretty confused when an object's __str__ method provides a unicode string. Calling... >>> str(desc) Traceback (most recent call last): File "<stdin>", line 1, in <module> UnicodeEncodeError: 'ascii' codec can't encode character u'\xab' in position 28: ordinal not in range(128) Providing an ascii str in python 2.x and unicode str in python 3.x. Thanks to Sathyanarayanan for the catch! 
Python 2.x gets pretty confused when an object's __str__ method provides a
unicode string. Calling...

>>> str(desc)
Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
UnicodeEncodeError: 'ascii' codec can't encode character u'\xab' in position 28: ordinal not in range(128)

Providing an ascii str in python 2.x and unicode str in python 3.x. Thanks to
Sathyanarayanan for the catch!
Adding copyright headers 2013-02-17T21:22:54+00:00 Damian Johnson atagar@torproject.org 2013-02-17T21:22:54+00:00 d70a2d394f24e471379906e561d80fb47ecd2230 Uggg I hate IP law. As pointed out by Juan on... https://trac.torproject.org/7954 ... we need copyright headers to properly comply with the requirements of being under the LGPL. I'm not looking forward to keeping this up to date (and likely won't), but oh well. I've added the header to all python source files except the unit and integ tests (patches welcome if someone wants to spend the time adding those too). These headers... * Declare a copyright from the year of the file's creation to now (2013). * Include Sean if he worked on it (he is the only contributor that hasn't made his contributions public domain to avoid copyright headaches). 
Uggg I hate IP law. As pointed out by Juan on...

https://trac.torproject.org/7954

... we need copyright headers to properly comply with the requirements of being
under the LGPL. I'm not looking forward to keeping this up to date (and likely
won't), but oh well.

I've added the header to all python source files except the unit and integ
tests (patches welcome if someone wants to spend the time adding those too).
These headers...

* Declare a copyright from the year of the file's creation to now (2013).

* Include Sean if he worked on it (he is the only contributor that hasn't made
  his contributions public domain to avoid copyright headaches).
Cleaning up our TODO comments 2013-02-17T20:25:43+00:00 Damian Johnson atagar@torproject.org 2013-02-17T20:25:43+00:00 4a2e7e74652c2c93654035bede41f203397ed16b Several of our TODO comments were no longer relevant or could be expanded. 
Several of our TODO comments were no longer relevant or could be expanded.
Treat descriptor archive contents as individual files 2013-02-17T05:53:24+00:00 Damian Johnson atagar@torproject.org 2013-02-17T05:53:24+00:00 6927e68d80bf78d898afe321a599bf174e116e40 When the descriptor reader encountered an archive and read non-descriptor content it stopped reading. This has caused me almost two weeks of headaches in troubleshooting... https://trac.torproject.org/8049 Changing the reader's behaviour to instead handle each file within the archive separately. Thanks to Karsten for catching this! 
When the descriptor reader encountered an archive and read non-descriptor
content it stopped reading. This has caused me almost two weeks of headaches in
troubleshooting...

https://trac.torproject.org/8049

Changing the reader's behaviour to instead handle each file within the archive
separately. Thanks to Karsten for catching this!
Adding get_archive_path() method to descriptors 2013-02-16T19:25:50+00:00 Damian Johnson atagar@torproject.org 2013-02-16T18:53:39+00:00 f83c7efce3380c60c81028802e198791aa30dfbd We can't use a TarInfo's 'name' attribute for get_path() since that corresponds to its location within the archive. That said, I've often wanted both paths so both fixing get_path() for tarballs and adding a get_archive_path(). 
We can't use a TarInfo's 'name' attribute for get_path() since that corresponds
to its location within the archive. That said, I've often wanted both paths so
both fixing get_path() for tarballs and adding a get_archive_path().
Dropping the 'path' argument from stem.descriptor.parse_file() 2013-02-16T18:28:07+00:00 Damian Johnson atagar@torproject.org 2013-02-15T17:38:02+00:00 8cdcb0883f0da8bb492da31cfea7155df5e9efed File objects have a 'name' attribute that we can use to guess the path. This isn't entirely reliable, but nothing is... http://stackoverflow.com/questions/2458676/absolute-path-of-a-file-object The path argument was only there to support the descriptor reader. Now that parse_file() is something for our users it's nice to get rid of arguments they can't use. 
File objects have a 'name' attribute that we can use to guess the path. This
isn't entirely reliable, but nothing is...

http://stackoverflow.com/questions/2458676/absolute-path-of-a-file-object

The path argument was only there to support the descriptor reader. Now that
parse_file() is something for our users it's nice to get rid of arguments they
can't use.
Accepting "NEVER" expiration in ADDRMAP events 2013-02-09T23:29:00+00:00 Damian Johnson atagar@torproject.org 2013-02-09T23:29:00+00:00 2a952ec98054cf656efd5d9b2bffa1960cdf5b42 The expiry value in ADDRMAP events can be 'NEVER'. This is a little troublesome since it means that the field might or might not be quoted (making this unique among all tor events). Caught by Desoxy on 'https://trac.torproject.org/8162'. 
The expiry value in ADDRMAP events can be 'NEVER'. This is a little troublesome
since it means that the field might or might not be quoted (making this unique
among all tor events).

Caught by Desoxy on 'https://trac.torproject.org/8162'.
Fixing SingleLineResponse interlinking 2013-02-09T21:11:10+00:00 Damian Johnson atagar@torproject.org 2013-02-09T21:07:23+00:00 dba169f5cb3d28da29c7c2011ef5de7cc5825d37 The SingleLineResponse class wasn't in the module's __all__, causing it to not appear in the sphinx output. 
The SingleLineResponse class wasn't in the module's __all__, causing it to not
appear in the sphinx output.
Improving stem.response.convert() pydocs 2013-02-09T20:53:31+00:00 Damian Johnson atagar@torproject.org 2013-02-09T20:53:31+00:00 74b60f7552b587ea576db0be01e31e0e5531bb7d The convert() pydocs were pretty clunky. Replacing the listing with a nice table mapping the response_type to classes, like what we do elsewhere. 
The convert() pydocs were pretty clunky. Replacing the listing with a nice
table mapping the response_type to classes, like what we do elsewhere.