summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
...
* | | | | | | | | | | Avoid double-free in bufferevent read/write cbsNick Mathewson2011-07-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes bug 3404; bugfix on 0.2.3.1-alpha.
* | | | | | | | | | | Merge remote-tracking branch 'origin/maint-0.2.2'Nick Mathewson2011-07-07
|\ \ \ \ \ \ \ \ \ \ \ | | |_|/ / / / / / / / | |/| | | | | | | | |
| * | | | | | | | | | Correctly send a SUCCEEDED event for rdns requestsSebastian Hahn2011-07-07
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The issue was that we overlooked the possibility of reverse DNS success at the end of connection_ap_handshake_socks_resolved(). Issue discovered by katmagic, thanks!
* | | | | | | | | | | Merge remote-tracking branch 'origin/maint-0.2.2'Nick Mathewson2011-07-06
|\ \ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / /
| * | | | | | | | | | Fix weird formatting of html manpageSebastian Hahn2011-07-06
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Asciidoc was inserting <pre> tags for paragraphs that started with a '+' at the beginning of the line. Instead, we need a space in front of the plus.
* | | | | | | | | | | Merge branch 'maint-0.2.2'Roger Dingledine2011-07-06
|\ \ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / /
| * | | | | | | | | | appease check-spacesRoger Dingledine2011-07-06
| | | | | | | | | | |
* | | | | | | | | | | Merge remote-tracking branch 'origin/maint-0.2.2'Nick Mathewson2011-07-05
|\ \ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / /
| * | | | | | | | | | Merge remote-tracking branch 'rransom-tor/bug3465-022' into maint-0.2.2Nick Mathewson2011-07-05
| |\ \ \ \ \ \ \ \ \ \
* | \ \ \ \ \ \ \ \ \ \ Merge remote-tracking branch 'rransom-tor/bug3465-023-v2'Nick Mathewson2011-07-05
|\ \ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | | Make handle_control_setevents table-drivenRobert Ransom2011-06-25
| | | | | | | | | | | | |
| * | | | | | | | | | | | Merge branch 'bug3465-022' into bug3465-023Robert Ransom2011-06-25
| |\ \ \ \ \ \ \ \ \ \ \ \ | | | |/ / / / / / / / / / | | |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | * bug3465-022: Add BUILDTIMEOUT_SET to the result of GETINFO events/names Correct a comment Fix minor comment issues
| | * | | | | | | | | | | Add BUILDTIMEOUT_SET to the result of GETINFO events/namesRobert Ransom2011-06-25
| | | | | | | | | | | | |
| | * | | | | | | | | | | Correct a commentRobert Ransom2011-06-24
| | | | | | | | | | | | |
| | * | | | | | | | | | | Fix minor comment issuesRobert Ransom2011-06-23
| | | | | | | | | | | | |
* | | | | | | | | | | | | Merge branch 'cov217_master'Nick Mathewson2011-07-01
|\ \ \ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | | | Check return value of crypto_global_init in test.cNick Mathewson2011-07-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This will let the unit tests fail in a less mystifying way if the crypto subsystem is b0rken, and will also make Coverity happier. CID # 429.
| * | | | | | | | | | | | | Defensive programming: don't crash with broken node_tNick Mathewson2011-07-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Every node_t has either a routerinfo_t or a routerstatus_t, so every node_t *should* have a nickname. Nonetheless, let's make sure in hex_digest_nickname_matches(). Should quiet CID 434.
| * | | | | | | | | | | | | Don't shadow parameters with local variablesNick Mathewson2011-07-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This is a little error-prone when the local has a different type from the parameter, and is very error-prone with both have the same type. Let's not do this. Fixes CID #437,438,439,440,441.
| * | | | | | | | | | | | | Replace 4 more sscanf()s with tor_sscanf()Nick Mathewson2011-07-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | For some inexplicable reason, Coverity departs from its usual standards of avoiding false positives here, and warns about all sscanf usage, even when the formatting strings are totally safe. Addresses CID # 447, 446.
| * | | | | | | | | | | | | Replace a "const const" with a "const"Nick Mathewson2011-07-01
| |/ / / / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Looks like this squeaked in while I was doing a search-and-replace to constify things. Coverity CID 483.
* | | | | | | | | | | | | Merge remote-tracking branch 'origin/maint-0.2.2'Nick Mathewson2011-07-01
|\ \ \ \ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / / / / |/| | / / / / / / / / / / | | |/ / / / / / / / / / | |/| | | | | | | | | |
| * | | | | | | | | | | Merge branch 'cov217_022_squashed' into maint-0.2.2Nick Mathewson2011-07-01
| |\ \ \ \ \ \ \ \ \ \ \
| | * | | | | | | | | | | Use strlcpy when copying node IDs into measured_bw_line_tNick Mathewson2011-07-01
| | |/ / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | We were using strncpy before, which isn't our style for stuff like this. This isn't a bug, though: before calling strncpy, we were checking that strlen(src) was indeed == HEX_DIGEST_LEN, which is less than sizeof(dst), so there was no way we could fail to NUL-terminate. Still, strncpy(a,b,sizeof(a)) is an idiom that we ought to squash everyplace. Fixes CID #427.
| * | | | | | | | | | | Merge branch 'cid30_changelog' into maint-0.2.2Nick Mathewson2011-07-01
| |\ \ \ \ \ \ \ \ \ \ \
| | * | | | | | | | | | | Add a changelog entry for cid30 fix.Nick Mathewson2011-07-01
| | |/ / / / / / / / / /
| * | | | | | | | | | | Merge remote-tracking branch 'origin/maint-0.2.1' into maint-0.2.2Nick Mathewson2011-07-01
| |\ \ \ \ \ \ \ \ \ \ \ | | |/ / / / / / / / / / | |/| | | / / / / / / / | | | |_|/ / / / / / / | | |/| | | | | | | |
| | * | | | | | | | | Merge branches 'cov217_021' and 'cid_450' into maint-0.2.1Nick Mathewson2011-07-01
| | |\ \ \ \ \ \ \ \ \
| | | * | | | | | | | | Fix insanely large stack_allocation in log_credential_statusNick Mathewson2011-07-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | I'm not one to insist on C's miserly stack limits, but allocating a 256K array on the stack is too much even for me. Bugfix on 0.2.1.7-alpha. Found by coverity. Fixes CID # 450.
| | * | | | | | | | | | Use strlcpy in create_unix_sockaddr()Nick Mathewson2011-07-01
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Using strncpy meant that if listenaddress were ever >= sizeof(sockaddr_un.sun_path), we would fail to nul-terminate sun_path. This isn't a big deal: we never read sun_path, and the kernel is smart enough to reject the sockaddr_un if it isn't nul-terminated. Nonetheless, it's a dumb failure mode. Instead, we should reject addresses that don't fit in sockaddr_un.sun_path. Coverity found this; it's CID 428. Bugfix on 0.2.0.3-alpha.
| | * | | | | | | | | | Fix a rare memory leak in rend_cache_storeNick Mathewson2011-07-01
| | |/ / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When we rejected a descriptor for not being the one we wanted, we were letting the parsed descriptor go out of scope. Found by Coverity; CID # 30. Bugfix on 0.2.1.26. (No changes file yet, since this is not in any 0.2.1.x release.)
* | | | | | | | | | | Merge remote-tracking branch 'rransom-tor/bug3456'Nick Mathewson2011-06-24
|\ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | Correct terminology in commentRobert Ransom2011-06-24
| | | | | | | | | | | |
| * | | | | | | | | | | Store cpath_build_state_t flags in one-bit bitfields, not intsRobert Ransom2011-06-24
| | | | | | | | | | | |
* | | | | | | | | | | | Merge branch 'master' of ssh://git-rw.torproject.org/torNick Mathewson2011-06-24
|\ \ \ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / / /
| * | | | | | | | | | | reach back in time and name a config option correctlyRoger Dingledine2011-06-23
| | | | | | | | | | | |
* | | | | | | | | | | | Merge remote-tracking branch 'origin/maint-0.2.2'Nick Mathewson2011-06-22
|\ \ \ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / / / |/| / / / / / / / / / / | |/ / / / / / / / / /
| * | | | | | | | | | Improve documentation of smartlist_split_stringRobert Ransom2011-06-22
| | | | | | | | | | |
| * | | | | | | | | | Fix minor comment issuesRobert Ransom2011-06-22
| | | | | | | | | | |
| * | | | | | | | | | Fix comment typoRobert Ransom2011-06-22
| | | | | | | | | | |
| * | | | | | | | | | explain that the ./publish should happen soon after the scpRoger Dingledine2011-06-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | otherwise you scp a tarball up but only one version of the website has it.
* | | | | | | | | | | Merge branch 'bug3367'Nick Mathewson2011-06-21
|\ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | Add, use a bufferevent-safe connection_flush()Nick Mathewson2011-06-21
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | A couple of places in control.c were using connection_handle_write() to flush important stuff (the response to a SIGNAL command, an ERR-level status event) before Tor went down. But connection_handle_write() isn't meaningful for bufferevents, so we'd crash. This patch adds a new connection_flush() that works for all connection backends, and makes control.c use that instead. Fix for bug 3367; bugfix on 0.2.3.1-alpha.
* | | | | | | | | | | | Merge remote-tracking branch 'public/bug3264'Nick Mathewson2011-06-21
|\ \ \ \ \ \ \ \ \ \ \ \
| * | | | | | | | | | | | Log SSL state changes at LOG_DEBUG, LD_HANDSHAKE.Nick Mathewson2011-06-20
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This can be slightly useful for debugging blocking events. Addresses ticket 3116; based on loud_ssl_states branch.
* | | | | | | | | | | | | forward-port the 0.2.2.29-beta changelog entryRoger Dingledine2011-06-21
| | | | | | | | | | | | |
* | | | | | | | | | | | | Fix tor-fw-helper-natpmp.c API usageJacob Appelbaum2011-06-20
|/ / / / / / / / / / / / | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | libnatpmp-20110618 changed the API that tor-fw-helper used and for a time tor-fw-helper could not build against the newest libnatpmp. This patch brings support for libnatpmp to tor-fw-helper.
* | | | | | | | | | | | Fix overwide line in config.cNick Mathewson2011-06-20
| | | | | | | | | | | |
* | | | | | | | | | | | Merge remote-tracking branch 'origin/maint-0.2.2'Nick Mathewson2011-06-20
|\ \ \ \ \ \ \ \ \ \ \ \ | |/ / / / / / / / / / / |/| / / / / / / / / / / | |/ / / / / / / / / /
| * | | | | | | | | | Fix overwide lines in util.cNick Mathewson2011-06-20
| | | | | | | | | | |
generated by cgit v1.2.1 (git 2.18.0) at 2024-02-08 07:50:45 +0000