<feed xmlns='http://www.w3.org/2005/Atom'>
<title>user/hoganrobert/tor, branch bug1138</title>
<subtitle>Robert's Tor repository</subtitle>
<link rel='alternate' type='text/html' href='https://gitweb.torproject.org/user/hoganrobert/tor.git/'/>
<entry>
<title>Handle null conn-&gt;requested_resource rather than assert</title>
<updated>2010-09-12T13:10:16+00:00</updated>
<author>
<name>Robert Hogan</name>
<email>robert@roberthogan.net</email>
</author>
<published>2010-09-12T13:10:16+00:00</published>
<link rel='alternate' type='text/html' href='https://gitweb.torproject.org/user/hoganrobert/tor.git/commit/?id=22ab997e8319fd0287c16ab8300d1bf69689f458'/>
<id>22ab997e8319fd0287c16ab8300d1bf69689f458</id>
<content type='text'>
Per arma's comments in bug1138
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Per arma's comments in bug1138
</pre>
</div>
</content>
</entry>
<entry>
<title>Nick points out:</title>
<updated>2010-09-02T21:17:43+00:00</updated>
<author>
<name>Robert Hogan</name>
<email>robert@roberthogan.net</email>
</author>
<published>2010-09-02T21:17:43+00:00</published>
<link rel='alternate' type='text/html' href='https://gitweb.torproject.org/user/hoganrobert/tor.git/commit/?id=5799cdd9d326740d79ec8a30b3ace90d0bda346e'/>
<id>5799cdd9d326740d79ec8a30b3ace90d0bda346e</id>
<content type='text'>
tor_assert(!conn-&gt;_base.purpose == DIR_PURPOSE_FETCH_EXTRAINFO)
!=
tor_assert(conn-&gt;_base.purpose != DIR_PURPOSE_FETCH_EXTRAINFO)
!!
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
tor_assert(!conn-&gt;_base.purpose == DIR_PURPOSE_FETCH_EXTRAINFO)
!=
tor_assert(conn-&gt;_base.purpose != DIR_PURPOSE_FETCH_EXTRAINFO)
!!
</pre>
</div>
</content>
</entry>
<entry>
<title>Amend per Sebastian's comments:</title>
<updated>2010-09-02T21:17:27+00:00</updated>
<author>
<name>Robert Hogan</name>
<email>robert@roberthogan.net</email>
</author>
<published>2010-08-31T19:45:44+00:00</published>
<link rel='alternate' type='text/html' href='https://gitweb.torproject.org/user/hoganrobert/tor.git/commit/?id=2086588efe9c7b378e3813f427d72eb2d135d661'/>
<id>2086588efe9c7b378e3813f427d72eb2d135d661</id>
<content type='text'>
 - Move checks for extra_info to callers
 - Change argument name from failed to descs
 - Use strlen("fp/") instead of a magic number
 - I passed on the suggestion to rename functions from *_failed() to
   *_handle_failure(). There are a lot of these so for now just follow
   the house style.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
 - Move checks for extra_info to callers
 - Change argument name from failed to descs
 - Use strlen("fp/") instead of a magic number
 - I passed on the suggestion to rename functions from *_failed() to
   *_handle_failure(). There are a lot of these so for now just follow
   the house style.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fall back to direct descriptor request to bridges when</title>
<updated>2010-08-16T20:15:49+00:00</updated>
<author>
<name>Robert Hogan</name>
<email>robert@roberthogan.net</email>
</author>
<published>2010-08-10T21:07:50+00:00</published>
<link rel='alternate' type='text/html' href='https://gitweb.torproject.org/user/hoganrobert/tor.git/commit/?id=d6744d611f933e77398ed80ac45cabfec16430c1'/>
<id>d6744d611f933e77398ed80ac45cabfec16430c1</id>
<content type='text'>
 requests to authorities fail due to a network error.

Bug#1138
"When a Tor client starts up using a bridge, and UpdateBridgesFromAuthority
is set, Tor will go to the authority first and look up the bridge by
fingerprint. If the bridge authority is filtered, Tor will never notice that
the bridge authority lookup failed. So it will never fall back."

Add connection_dir_bridge_routerdesc_failed(), a function for unpacking
the bridge information from a failed request, and ensure
connection_dir_request_failed() calls it if the failed request
was for a bridge descriptor.

Test:

1. for ip in `grep -iR 'router ' cached-descriptors|cut -d ' ' -f 3`;
do sudo iptables -A OUTPUT -p tcp -d $ip -j DROP; done
2. remove all files from user tor directory
3. Put the following in torrc:

UseBridges 1
UpdateBridgesFromAuthority 1
Bridge 85.108.88.19:443 7E1B28DB47C175392A0E8E4A287C7CB8686575B7

4. Launch tor - it should fall back to downloading descriptors
   directly from the bridge.

Initial patch reviewed and corrected by mingw-san.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
 requests to authorities fail due to a network error.

Bug#1138
"When a Tor client starts up using a bridge, and UpdateBridgesFromAuthority
is set, Tor will go to the authority first and look up the bridge by
fingerprint. If the bridge authority is filtered, Tor will never notice that
the bridge authority lookup failed. So it will never fall back."

Add connection_dir_bridge_routerdesc_failed(), a function for unpacking
the bridge information from a failed request, and ensure
connection_dir_request_failed() calls it if the failed request
was for a bridge descriptor.

Test:

1. for ip in `grep -iR 'router ' cached-descriptors|cut -d ' ' -f 3`;
do sudo iptables -A OUTPUT -p tcp -d $ip -j DROP; done
2. remove all files from user tor directory
3. Put the following in torrc:

UseBridges 1
UpdateBridgesFromAuthority 1
Bridge 85.108.88.19:443 7E1B28DB47C175392A0E8E4A287C7CB8686575B7

4. Launch tor - it should fall back to downloading descriptors
   directly from the bridge.

Initial patch reviewed and corrected by mingw-san.
</pre>
</div>
</content>
</entry>
<entry>
<title>fix another piece of 1741</title>
<updated>2010-08-14T08:22:08+00:00</updated>
<author>
<name>Roger Dingledine</name>
<email>arma@torproject.org</email>
</author>
<published>2010-08-14T08:22:08+00:00</published>
<link rel='alternate' type='text/html' href='https://gitweb.torproject.org/user/hoganrobert/tor.git/commit/?id=a207d9db4ccf3c7430f0b9fe97959be6fe4912be'/>
<id>a207d9db4ccf3c7430f0b9fe97959be6fe4912be</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>changes entry for bug 1741</title>
<updated>2010-08-14T00:50:51+00:00</updated>
<author>
<name>Roger Dingledine</name>
<email>arma@torproject.org</email>
</author>
<published>2010-08-14T00:50:51+00:00</published>
<link rel='alternate' type='text/html' href='https://gitweb.torproject.org/user/hoganrobert/tor.git/commit/?id=e50857b67f23d06671d2856a04879c3425747adf'/>
<id>e50857b67f23d06671d2856a04879c3425747adf</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Add check for CIRCUIT_PURPOSE_S_REND_JOINED.</title>
<updated>2010-08-14T00:46:33+00:00</updated>
<author>
<name>Mike Perry</name>
<email>mikeperry-git@fscked.org</email>
</author>
<published>2010-07-27T15:45:23+00:00</published>
<link rel='alternate' type='text/html' href='https://gitweb.torproject.org/user/hoganrobert/tor.git/commit/?id=5b0c0e1f89b020f4fc50fa1b50edbb17fa776fe4'/>
<id>5b0c0e1f89b020f4fc50fa1b50edbb17fa776fe4</id>
<content type='text'>
These circuits stick around much longer than others on the server side for
performance reasons. Their lifetime is controlled by the client.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
These circuits stick around much longer than others on the server side for
performance reasons. Their lifetime is controlled by the client.
</pre>
</div>
</content>
</entry>
<entry>
<title>fix a memory leak introduced by df1ef2f0f0856af</title>
<updated>2010-08-13T21:30:50+00:00</updated>
<author>
<name>Roger Dingledine</name>
<email>arma@torproject.org</email>
</author>
<published>2010-08-13T21:30:50+00:00</published>
<link rel='alternate' type='text/html' href='https://gitweb.torproject.org/user/hoganrobert/tor.git/commit/?id=b1a588855380d021b536f42b70c9815b83eca430'/>
<id>b1a588855380d021b536f42b70c9815b83eca430</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>fold in the makefile.am changes entry</title>
<updated>2010-08-13T21:19:04+00:00</updated>
<author>
<name>Roger Dingledine</name>
<email>arma@torproject.org</email>
</author>
<published>2010-08-13T21:19:04+00:00</published>
<link rel='alternate' type='text/html' href='https://gitweb.torproject.org/user/hoganrobert/tor.git/commit/?id=a1686d867e0a35417e1e65ad0730bcd116edd10f'/>
<id>a1686d867e0a35417e1e65ad0730bcd116edd10f</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>minor formatting / comment fixes</title>
<updated>2010-08-13T21:18:45+00:00</updated>
<author>
<name>Roger Dingledine</name>
<email>arma@torproject.org</email>
</author>
<published>2010-08-13T21:18:45+00:00</published>
<link rel='alternate' type='text/html' href='https://gitweb.torproject.org/user/hoganrobert/tor.git/commit/?id=1ac1f048effdfde062de33e4572cd7816e7be03c'/>
<id>1ac1f048effdfde062de33e4572cd7816e7be03c</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
