summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authoriwakeh <iwakeh@torproject.org>2018-03-15 13:58:20 +0000
committeriwakeh <iwakeh@torproject.org>2018-03-15 13:58:20 +0000
commit1a54193454dd0bdcbc144c6aeed63c51f72e3e76 (patch)
tree0764a7135243f2a2d36abc7f42fe2df1718ba1b0
parent0f63aa5f4d1fed28f42f8763f77dfc76b37e9a48 (diff)
fixup! Only unescape valid UTF.task-22594
-rw-r--r--src/main/java/org/torproject/onionoo/server/ResponseBuilder.java5
1 files changed, 2 insertions, 3 deletions
diff --git a/src/main/java/org/torproject/onionoo/server/ResponseBuilder.java b/src/main/java/org/torproject/onionoo/server/ResponseBuilder.java
index bb36a2c..e2bdf82 100644
--- a/src/main/java/org/torproject/onionoo/server/ResponseBuilder.java
+++ b/src/main/java/org/torproject/onionoo/server/ResponseBuilder.java
@@ -12,12 +12,11 @@ import org.torproject.onionoo.docs.DocumentStoreFactory;
import org.torproject.onionoo.docs.SummaryDocument;
import org.torproject.onionoo.docs.UptimeDocument;
import org.torproject.onionoo.docs.WeightsDocument;
+import org.torproject.onionoo.util.FormattingUtils;
import com.google.gson.Gson;
import com.google.gson.GsonBuilder;
-import org.apache.commons.lang3.StringUtils;
-
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
@@ -348,7 +347,7 @@ public class ResponseBuilder {
/* Whenever we provide Gson with a string containing an escaped
* non-ASCII character like \u00F2, it escapes the \ to \\, which
* we need to undo before including the string in a response. */
- return StringUtils.replace(gson.toJson(dd), "\\\\u", "\\u");
+ return FormattingUtils.replaceValidUtf(gson.toJson(dd));
} else {
// TODO We should probably log that we didn't find a details
// document that we expected to exist.