<feed xmlns='http://www.w3.org/2005/Atom'>
<title>user/karsten/tor, branch karsten/ticket40226_045_01</title>
<subtitle>Karsten's Tor repository</subtitle>
<link rel='alternate' type='text/html' href='https://gitweb.torproject.org/user/karsten/tor.git/'/>
<entry>
<title>Fix timestamp parser in new load_stats_file.</title>
<updated>2020-12-16T08:58:19+00:00</updated>
<author>
<name>Karsten Loesing</name>
<email>karsten.loesing@gmx.net</email>
</author>
<published>2020-12-16T08:58:19+00:00</published>
<link rel='alternate' type='text/html' href='https://gitweb.torproject.org/user/karsten/tor.git/commit/?id=97274e30689ced255e04e3d6ef8ba2cc40f7d7e8'/>
<id>97274e30689ced255e04e3d6ef8ba2cc40f7d7e8</id>
<content type='text'>
The previous parser only considered stats files _starting_ with the
timestamp tag, not stats files having the timestamp tag in a later
position. While this applies to all current stats files, a future
stats file might look differently. Better to fix the function now than
be surprised in another 9 years from now.

This commit also adds a test case for such future stats, and it fixes
stats file paths in newly added unit tests.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The previous parser only considered stats files _starting_ with the
timestamp tag, not stats files having the timestamp tag in a later
position. While this applies to all current stats files, a future
stats file might look differently. Better to fix the function now than
be surprised in another 9 years from now.

This commit also adds a test case for such future stats, and it fixes
stats file paths in newly added unit tests.
</pre>
</div>
</content>
</entry>
<entry>
<title>relay: Report the entire content of a stats file</title>
<updated>2020-12-15T16:51:59+00:00</updated>
<author>
<name>David Goulet</name>
<email>dgoulet@torproject.org</email>
</author>
<published>2020-12-15T16:41:42+00:00</published>
<link rel='alternate' type='text/html' href='https://gitweb.torproject.org/user/karsten/tor.git/commit/?id=1138adc443d1d508fb9f4742084fb97551319fa5'/>
<id>1138adc443d1d508fb9f4742084fb97551319fa5</id>
<content type='text'>
It turns out that 9 years ago, we stopped appending data into stats file and
rather overwrite everytime we have new stats (see commit
a6a127c833eace1100aca7ab8ad118862bb8a8b9)

The load_stats_file() function was still thinking that we could have the same
line many times in the file which turns out to be false since 9 years ago.
However, that did not cause problem until IPv6 connection stats came along
which introduced a new line in conn-stats: "ipv6-conn-bi-direct ...".

Before, that file contained a single line starting with the tag
"conn-bi-direct".  That very tag appears also in the IPv6 tag (see above) so
the load_stats_file() function would consider that the IPv6 line as the last
tag to be appeneded to the file and fail to report the line above (for IPv4).
It would actually truncate the IPv6 line and report it (removing the "ipv6-"
part).

In other words, "conn-bi-direct" was not reported and instead
"ipv6-conn-bi-direct" was used without the "ipv6-" part.

This commit refactors the entire function so that now it looks for a
"timestamp tag" to validate and then if everything is fine, returns the entire
content of the file. The refactor simplifies the function, adds logging in
case of failures and modernize it in terms of coding standard.

Unit tests are also added that makes sure the loaded content matches the
entire file if timestamp validation passes.

Fixes #40226

Signed-off-by: David Goulet &lt;dgoulet@torproject.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
It turns out that 9 years ago, we stopped appending data into stats file and
rather overwrite everytime we have new stats (see commit
a6a127c833eace1100aca7ab8ad118862bb8a8b9)

The load_stats_file() function was still thinking that we could have the same
line many times in the file which turns out to be false since 9 years ago.
However, that did not cause problem until IPv6 connection stats came along
which introduced a new line in conn-stats: "ipv6-conn-bi-direct ...".

Before, that file contained a single line starting with the tag
"conn-bi-direct".  That very tag appears also in the IPv6 tag (see above) so
the load_stats_file() function would consider that the IPv6 line as the last
tag to be appeneded to the file and fail to report the line above (for IPv4).
It would actually truncate the IPv6 line and report it (removing the "ipv6-"
part).

In other words, "conn-bi-direct" was not reported and instead
"ipv6-conn-bi-direct" was used without the "ipv6-" part.

This commit refactors the entire function so that now it looks for a
"timestamp tag" to validate and then if everything is fine, returns the entire
content of the file. The refactor simplifies the function, adds logging in
case of failures and modernize it in terms of coding standard.

Unit tests are also added that makes sure the loaded content matches the
entire file if timestamp validation passes.

Fixes #40226

Signed-off-by: David Goulet &lt;dgoulet@torproject.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge remote-tracking branch 'tor-gitlab/mr/205' into maint-0.4.5</title>
<updated>2020-12-15T14:28:49+00:00</updated>
<author>
<name>George Kadianakis</name>
<email>desnacked@riseup.net</email>
</author>
<published>2020-12-15T14:28:49+00:00</published>
<link rel='alternate' type='text/html' href='https://gitweb.torproject.org/user/karsten/tor.git/commit/?id=c731a4efec3c7206bbbb8d2ba39c970fcb0c9f36'/>
<id>c731a4efec3c7206bbbb8d2ba39c970fcb0c9f36</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Avoid sandbox bug warning when unglobbing patterns #40094</title>
<updated>2020-12-08T20:00:43+00:00</updated>
<author>
<name>Daniel Pinto</name>
<email>danielpinto52@gmail.com</email>
</author>
<published>2020-11-13T01:08:56+00:00</published>
<link rel='alternate' type='text/html' href='https://gitweb.torproject.org/user/karsten/tor.git/commit/?id=bd0046c9ec5bf6556d4ecf6b111b0de4c0266ebd'/>
<id>bd0046c9ec5bf6556d4ecf6b111b0de4c0266ebd</id>
<content type='text'>
Adds a more user-friendly error message when the configuration is
reloaded and a new %include is added that makes its unglobbing
access files/folders not allowed by the seccomp sandbox.
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Adds a more user-friendly error message when the configuration is
reloaded and a new %include is added that makes its unglobbing
access files/folders not allowed by the seccomp sandbox.
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix a couple of documentation comments related to #40094</title>
<updated>2020-12-08T19:59:28+00:00</updated>
<author>
<name>Nick Mathewson</name>
<email>nickm@torproject.org</email>
</author>
<published>2020-12-08T19:59:28+00:00</published>
<link rel='alternate' type='text/html' href='https://gitweb.torproject.org/user/karsten/tor.git/commit/?id=baef0843a424116026f3f97185dae89271903041'/>
<id>baef0843a424116026f3f97185dae89271903041</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>relay: Avoid log reachability test for bandwidth test circuit</title>
<updated>2020-12-08T19:51:31+00:00</updated>
<author>
<name>David Goulet</name>
<email>dgoulet@torproject.org</email>
</author>
<published>2020-12-08T16:58:10+00:00</published>
<link rel='alternate' type='text/html' href='https://gitweb.torproject.org/user/karsten/tor.git/commit/?id=e74f168bb4df0b06d4f224421570e160cfcdb7a9'/>
<id>e74f168bb4df0b06d4f224421570e160cfcdb7a9</id>
<content type='text'>
Fixes #40205

Signed-off-by: David Goulet &lt;dgoulet@torproject.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fixes #40205

Signed-off-by: David Goulet &lt;dgoulet@torproject.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>configure: Fix the --enable-static-tor switch</title>
<updated>2020-12-08T14:14:49+00:00</updated>
<author>
<name>David Goulet</name>
<email>dgoulet@torproject.org</email>
</author>
<published>2020-11-18T16:24:38+00:00</published>
<link rel='alternate' type='text/html' href='https://gitweb.torproject.org/user/karsten/tor.git/commit/?id=c618c4f27986825df2026fb22b8ee222edd1afa1'/>
<id>c618c4f27986825df2026fb22b8ee222edd1afa1</id>
<content type='text'>
The "-static" compile flag was set globally which means that all autoconf test
were attempting to be built statically and lead to failures of detecting
OpenSSL libraries and others.

This commit adds this flag only to the "tor" binary build.

There is also a fix on where to find libevent.a since it is using libtool, it
is in .libs/.

At this commit, there are still warnings being emitted that informs the user
that the built binary must still be linked dynamically with glibc.

Fixes #40111

Signed-off-by: David Goulet &lt;dgoulet@torproject.org&gt;
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
The "-static" compile flag was set globally which means that all autoconf test
were attempting to be built statically and lead to failures of detecting
OpenSSL libraries and others.

This commit adds this flag only to the "tor" binary build.

There is also a fix on where to find libevent.a since it is using libtool, it
is in .libs/.

At this commit, there are still warnings being emitted that informs the user
that the built binary must still be linked dynamically with glibc.

Fixes #40111

Signed-off-by: David Goulet &lt;dgoulet@torproject.org&gt;
</pre>
</div>
</content>
</entry>
<entry>
<title>bump to 0.4.5.2-alpha-dev</title>
<updated>2020-11-23T19:03:53+00:00</updated>
<author>
<name>Nick Mathewson</name>
<email>nickm@torproject.org</email>
</author>
<published>2020-11-23T19:03:14+00:00</published>
<link rel='alternate' type='text/html' href='https://gitweb.torproject.org/user/karsten/tor.git/commit/?id=2f87b2ab75e29cbd9ee2989c5e7739234818e4d4'/>
<id>2f87b2ab75e29cbd9ee2989c5e7739234818e4d4</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Bump to 0.4.5.2-alpha.</title>
<updated>2020-11-21T20:09:08+00:00</updated>
<author>
<name>Nick Mathewson</name>
<email>nickm@torproject.org</email>
</author>
<published>2020-11-21T20:09:08+00:00</published>
<link rel='alternate' type='text/html' href='https://gitweb.torproject.org/user/karsten/tor.git/commit/?id=73fb44dcba29713d777430bd3278a8bc6c2e9e70'/>
<id>73fb44dcba29713d777430bd3278a8bc6c2e9e70</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Merge branch 'maint-0.4.4' into maint-0.4.5</title>
<updated>2020-11-19T17:44:00+00:00</updated>
<author>
<name>Alexander Færøy</name>
<email>ahf@torproject.org</email>
</author>
<published>2020-11-19T17:44:00+00:00</published>
<link rel='alternate' type='text/html' href='https://gitweb.torproject.org/user/karsten/tor.git/commit/?id=b274e46309b4375f6014f3b698ea24b32d4935a5'/>
<id>b274e46309b4375f6014f3b698ea24b32d4935a5</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
</feed>
