| Commit message (Collapse) | Author | Age |
|---|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| | |
|
| |
|
|
|
|
|
|
| |
Whitespace issues
Line length
Unused variable
|
| | |
|
| | |
|
| |
|
|
| |
We'd broken this with the recent _free() rewrite.
|
| | |
|
| |\ |
|
| | |
| |
| |
| |
| | |
These tests primarily test the relaxed and measured behavior of
circuitstats.c, to make sure we did not break it with #23100 or #23114.
|
| | |
| |
| |
| |
| | |
Bug #23114 was harder to see because we were just reporting our math,
rather than reporting behavior.
|
| | |
| |
| |
| |
| | |
This changes the purpose of circuits that are past the timeout to measurement
*as they are built*, ensuring accurate application of the timeout logic.
|
| | |
| |
| |
| |
| | |
This change causes us to count anything once it reaches 3 hops (but not
after).
|
| | | |
|
| |\ \ |
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This commit was made mechanically by this perl script:
\#!/usr/bin/perl -w -i -p
next if /^#define FREE_AND_NULL/;
s/\bFREE_AND_NULL\((\w+),/FREE_AND_NULL\(${1}_t, ${1}_free_,/;
s/\bFREE_AND_NULL_UNMATCHED\(/FREE_AND_NULL\(/;
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
This commit removes the old FREE_AND_NULL, and renames the old
FREE_AND_NULL_UNMATCHED so that it is now called FREE_AND_NULL.
This will break all the FREE_AND_NULL_* users; the next commit will
fix them.
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | | |
This one only evaluates the input once, so it cannot mess up even if
there are side effects.
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | |
| | |
| | |
| | | |
This covers addressmap.h (no change needed) through confparse.h
|
| | | | |
|
| | | | |
|
| | | | |
|
| | | | |
|
| |\ \ \ |
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Closes #23709
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
| | | | |
| | | |
| | | |
| | | | |
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
Couple things happen in this commit. First, we do not re-queue a cell back in
the circuit queue if the write packed cell failed. Currently, it is close to
impossible to have it failed but just in case, the channel is mark as closed
and we move on.
The second thing is that the channel_write_packed_cell() always took ownership
of the cell whatever the outcome. This means, on success or failure, it needs
to free it.
It turns out that that we were using the wrong free function in one case and
not freeing it in an other possible code path. So, this commit makes sure we
only free it in one place that is at the very end of
channel_write_packed_cell() which is the top layer of the channel abstraction.
This makes also channel_tls_write_packed_cell_method() return a negative value
on error.
Two unit tests had to be fixed (quite trivial) due to a double free of the
packed cell in the test since now we do free it in all cases correctly.
Part of #23709
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
| | | | |
| | | |
| | | |
| | | | |
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
| | | | |
| | | |
| | | |
| | | | |
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
| | | | |
| | | |
| | | |
| | | | |
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
| | | | |
| | | |
| | | |
| | | | |
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
| | | | |
| | | |
| | | |
| | | | |
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
| | | | |
| | | |
| | | |
| | | | |
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
| | | | |
| | | |
| | | |
| | | | |
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
| | | | |
| | | |
| | | |
| | | | |
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
They were broken due to previous commit. Fixes are trivial.
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
| | | | |
| | | |
| | | |
| | | | |
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
| | | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | |
| | | | |
First, that test was broken from the previous commit because the
channel_queue_cell() has been removed. This now tests the
channel_process_cell() directly.
Second, it wasn't testing much except if the channel subsystem actually went
through the cell handler. This commit adds more checks on the state of a
channel going from open, receiving a cell and closing.
Third, this and the id_map unit test are working, not the others so they've
been marked as not working and future commit will improve and fix those.
Signed-off-by: David Goulet <dgoulet@torproject.org>
|
