| Commit message (Collapse) | Author | Age |
| ... | |
| | |
| |
| |
| |
| | |
Otherwise, we'd also have to pass the `transport`, and `addressClass`
parameters to renderAnswer().
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| | |
* CHANGE bridgedb.parse.networkstatus.parseRLine() to check the OR
nickname validity only after parsing (and readding the base64 padding
to) the OR ID digest.
* ADD inline comments about why this is done.
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
* MOVE logic for parsing filternames from the "unique string" in method
FilteredBridgeSplitter.addRing() to new method
FilteredBridgeSplitter.extractFilterNames().
* ADD a FilteredBridgeSplitter.distributorName attribute which is set
when Dist.Distributor.setDistributorName() is called.
* REFACTOR FilteredBridgeSplitter.addRing() to use the new subring names.
|
| |\ \ |
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | | |
* FIXES #10559
* FIXES a bunch of PEP8 problems.
* CHANGE getTransportLine() to use `' '.join()` rather than formatting the
bridge line inside the return statement. It's faster and safer.
|
| | | | |
|
| | | |
| | |
| | |
| | |
| | |
| | | |
This is to see if they are ever actually passed into this function. They
weren't being used anywhere inside BridgeRing.getBridges(), nor anywhere
else.
|
| |/ /
| |
| |
| | |
* REMOVE the comment and other cruft around it.
|
| |\ \ |
|
| | | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | |
| | | |
* ADD a wrapper which catches all unhandled exceptions which occur
while generating an HTML response. If such an exception occurs, this
ensures that the error is logged and the default "No bridges
currently available" response is served to the client (rather than
display a traceback to the client, which is what BridgeDB did
previously).
* FIXES #6127
|
| |/ /
| |
| |
| |
| |
| |
| |
| | |
* MOVE logic for generating HTML responses out of
bridgedb.HTTPServer.WebResource.getBridgeRequestAnswer() and into a
new method, bridgedb.HTTPServer.WebResource.renderAnswer(). This
allows other methods to generate responses, even if the request was
malformed.
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| |
| | |
See https://travis-ci.org/isislovecruft/bridgedb/jobs/16798991#L1591, it
was erroring because it expected the default hashring name for every
hashring which was prepopulated.
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
This class currently serves very little purpose because I am still
nervous about making major changes to the IPBasedDistributor and
EmailBasedDistributor classes. However, I did add functionality for
naming a Distributor's hashrings after the distributor's class, so that
which hashring a bridge is being added to is much clearer in the logs.
* ADD bridgedb.Dist.Distributor class.
* CHANGE IPBasedDistributor and EmailBasedDistributor to inherit from
Distributor.
* ADD functionality for naming hashrings after their distributor.
|
| | | |
|
| | |
| |
| |
| |
| | |
* FIXES several lines which are too long.
* FIXES a couple whitespace problems.
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| | |
* FIXES several PEP8 problems due to lines being too long.
* FIXES one cute PEP8 problem; a semicolon which was placed after a
`break` in a `for` loop, probably by someone whose fingers are used
to coding in C.
* FIXES one PEP8 problem due to continuation of an `if` clause on the
same line.
|
| | |
| |
| |
| |
| |
| | |
Several `if` clauses are split to the next line, and an unneeded
line-continued backslash is removed from the parameters for a call to
the logger.
|
| | |
| |
| |
| | |
These are all whitespace changes ― nothing else is touched.
|
| | | |
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| |
| | |
The logging before was quite messy.
The sub hashrings are identified by the HMAC of a unique string. It
turns out that the "unique string" which is used in this case is
actually something which looks like the class.__repr__() for a
bridgedb.Bridges.BridgeHolder subclass. This is *probably* unique
because it contains memory addresses of the newly generated hmac_fn()s,
which are likely (though not necessarily) unique. This is a bit gross,
in my opinion, but it's not really a problem.
However, the log messages this function generated are a problem. They
contain memory addresses, which isn't the greatest idea, ignoring all
other reasons, simply because it's illegible.
* REFACTOR logging statements in
bridgedb.Bridges.FilteredBridgeSplitter.prepopulateRings() to remove
logging of hmac_fn() memory addresses.
* ADD a long comment detailing the "unique strings" which identify a
sub hashring, and how they should probably be changed someday.
|
| | | |
|
| | |
| |
| |
| |
| |
| |
| |
| | |
In bridgedb.Bridges.FilteredBridgeSplitter.prepopulateRings(), we return
False if we were unable to prepopulate bridges into the sub hashring for
whatever reason. In case some calling function wants to use the boolean
return value as a check, we should mirror this logic and return True if
prepopulation was successful.
|