user/sebastian/stem, branch gabelmoo

Gabelmoo's IP address changed

2015-02-09T19:17:54+00:00

Our ONLINE target could fail with an undefined 'streams'

2015-02-09T17:07:08+00:00

Doesn't make the test pass, but was masking the actual issue which is
"SocksError: [6] TTL expired".

======================================================================
ERROR: test_attachstream
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/atagar/Desktop/stem/test/integ/control/controller.py", line 1206, in test_attachstream
    our_stream = [stream for stream in streams if stream.target_address == host][0]
UnboundLocalError: local variable 'streams' referenced before assignment

Better argument handling for run_tests.py

2015-02-09T16:50:45+00:00

Balking if provided with unrecognized arguments, and more intuitive handling
for targets...

  https://trac.torproject.org/projects/tor/ticket/14804

Rather than error, keep the default target when none are provided

2015-02-09T16:37:54+00:00

Actually, on reflection if the user only provides attribute targets (ex.
'--target ONLINE') there's no point in erroring. They clearly want to keep the
default.

Warn if user doesn't provide any runnable integ targets

2015-02-09T16:30:20+00:00

Sebastian was understandably confused on ticket 14804 when running '--target
ONLINE' didn't run anything.

Balk if an unrecognized argument is provided

2015-02-09T16:26:22+00:00

Interesting, thought getopt did this. For both run_tests.py and the tor-prompt
providing an error when unrecognized arguments are provided. Caught by
Sebastian on...

  https://trac.torproject.org/projects/tor/ticket/14804

The run_tests.py's -t argument aliased to two things

2015-02-09T16:01:11+00:00

The '-t' argument was an alias for '--target' and '--test'. In practice and
according to the help output it was actually just the former. This souldn't
actually change anything, just clarifying the code. Found as part of...

  https://trac.torproject.org/projects/tor/ticket/14804

Don't run test for 'tor --version' when using the RUN_NONE target

2015-02-09T15:58:31+00:00

This test compares the output to 'GETINFO version' so being unable to connect
to tor breaks the test.

Don't hardcode /tmp/foo as a test path

2015-02-09T15:53:12+00:00

Turns out I make foo test paths a lot. Running 'mkdir /tmp/foo' for something
else broke the unit tests for me. Easy enough to do the proper thing and pick a
random unused path.

Test tor's commandline arguments

2015-02-09T04:27:57+00:00

Moving a revised version of tor's test_cmdline_args.py into our process tests.
Now that tor has a make target for using Stem to supplement its tests this is
the right home for them.

  https://trac.torproject.org/projects/tor/ticket/14109