summaryrefslogtreecommitdiff
Commit message (Collapse)AuthorAge
* ClientDNSRejectInternalAddresses in non-default networksticket21031_v2Sebastian Hahn2017-11-04
| | | | | Once again allow the flag to be set, unless the default network is used. Thanks to nickm for a suggestion for the workaround to a test failure.
* Undo deprecation of ClientDNSRejectInternalAddressesSebastian Hahn2017-11-04
|
* Revert "Make ClientDNSRejectInternalAddresses testing-only."Sebastian Hahn2017-11-04
| | | | This reverts commit 27fa4a98d23972213122fa99499efa4baebe49e3.
* nodelist: Downgrade warning to protocol warningDavid Goulet2017-11-02
| | | | | | | | | | The node_get_ed25519_id() warning can actually be triggered by a relay flagged with NoEdConsensus so instead of triggering a warning on all relays of the network, downgrade it to protocol warning. Fixes #24025 Signed-off-by: David Goulet <dgoulet@torproject.org>
* Merge branch 'dgoulet_ticket23753_032_02_squashed' into maint-0.3.2Nick Mathewson2017-11-02
|\
| * sched: Rate limit scheduler_bug_occurred()David Goulet2017-11-02
| | | | | | | | | | | | | | Just in case we end up hitting a SCHED_BUG() multiple times, rate limit the log warning. Signed-off-by: David Goulet <dgoulet@torproject.org>
| * sched: Add another SCHED_BUG() callsiteMatt Traudt2017-11-02
| |
| * sched: Use SCHED_BUG() macro in schedulerDavid Goulet2017-11-02
| | | | | | | | | | | | | | | | | | | | When a BUG() occurs, this macro will print extra information about the state of the scheduler and the given channel if any. This will help us greatly to fix future bugs in the scheduler especially when they occur rarely. Fixes #23753 Signed-off-by: David Goulet <dgoulet@torproject.org>
| * sched: Implement SCHED_BUG()David Goulet2017-10-03
| | | | | | | | Signed-off-by: David Goulet <dgoulet@torproject.org>
* | Test that IPv6-only clients can use microdescriptorsteor2017-11-02
| | | | | | | | | | | | | | | | | | | | When running "make test-network-all", test that IPv6-only clients can use microdescriptors. IPv6-only microdescriptor client support was fixed in tor 0.3.0.1-alpha. Requires chutney master 61c28b9 or later. Closes ticket 24109.
* | Tweak a comment for a minor but important distinctionNick Mathewson2017-11-02
| |
* | Merge branch 'ticket23820_032_01_squashed' into maint-0.3.2Nick Mathewson2017-11-02
|\ \
| * | Changes file for 23820teor2017-11-02
| | |
| * | Don't run IPv6-only v3 single onion service tests using chutneyteor2017-11-02
| | | | | | | | | | | | Part of #23820.
| * | Stop users configuring IPv6-only v3 single onion servicesteor2017-11-02
| | | | | | | | | | | | | | | | | | | | | They are not yet implemented: they will upload descriptors, but won't be able to rendezvous, because IPv6 addresses in link specifiers are ignored. Part of #23820.
| * | Improve v3 onion service logging for intro and rend pointsteor2017-11-02
| | | | | | | | | | | | Diagnostics for #23820.
| * | Remove buggy IPv6 and ed25519 handling from get_lspecs_from_extend_info()teor2017-11-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous version of this function had the following issues: * it didn't check if the extend_info contained an IPv6 address, * it didn't check if the ed25519 identity key was valid. But we can't add IPv6 support in a bugfix release. Instead, BUG() if the address is an IPv6 address, so we always put IPv4 addresses in link specifiers. And ignore missing ed25519 identifiers, rather than generating an all-zero link specifier. This supports v3 hidden services on IPv4, dual-stack, and IPv6, and v3 single onion services on IPv4 only. Part of 23820, bugfix on 0.3.2.1-alpha.
| * | Remove buggy IPv6 support from pick_intro_point() and service_intro_point_new()teor2017-10-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous version of these functions had the following issues: * they can't supply both the IPv4 and IPv6 addresses in link specifiers, * they try to fall back to a 3-hop path when the address for a direct connection is unreachable, but this isn't supported by launch_rendezvous_point_circuit(), so it fails. But we can't fix these things in a bugfix release. Instead, always put IPv4 addresses in link specifiers. And if a v3 single onion service can't reach any intro points, fail. This supports v3 hidden services on IPv4, dual-stack, and IPv6, and v3 single onion services on IPv4 only. Part of 23820, bugfix on 0.3.2.1-alpha.
| * | Remove buggy IPv6 support from hs_get_extend_info_from_lspecs()teor2017-10-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The previous version of this function has the following issues: * it doesn't choose between IPv4 and IPv6 addresses correctly, and * it doesn't fall back to a 3-hop path when the address for a direct connection is unreachable. But we can't fix these things in a bugfix release. Instead, treat IPv6 addresses like any other unrecognised link specifier and ignore them. If there is no IPv4 address, return NULL. This supports v3 hidden services on IPv4, dual-stack, and IPv6, and v3 single onion services on IPv4 only. Part of 23820, bugfix on 0.3.2.1-alpha.
* | | man: Specify HiddenServiceNumIntroductionPoints for v3David Goulet2017-11-01
| | | | | | | | | | | | | | | | | | | | | | | | A v3 service can have between 0 and 20 intro points where v2 has 0 to 10. Fixes #24115 Signed-off-by: David Goulet <dgoulet@torproject.org>
* | | Merge branch 'bug24082_032' into maint-0.3.2Nick Mathewson2017-10-31
|\ \ \
| * | | Initialize the mock options in the fuzzing codeNick Mathewson2017-10-30
| | | | | | | | | | | | | | | | Fixes bug 24082; bugfix on 0.3.0.3-alpha. Found by Brian Carpenter.
* | | | double newlineNick Mathewson2017-10-31
| | | |
* | | | Merge branch 'hsdescv3_fuzz_more' into maint-0.3.2Nick Mathewson2017-10-31
|\ \ \ \
| * | | | In the hsdescv3 fuzzer, replace the decryption function.Nick Mathewson2017-10-27
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | The new decryption function performs no decryption, skips the salt, and doesn't check the mac. This allows us to fuzz the hs_descriptor.c code using unencrypted descriptor test, and exercise more of the code. Related to 21509.
* | | | | make 23762 changes file pass check-changesNick Mathewson2017-10-31
| | | | |
* | | | | Merge branch 'bug23762_032_02_squashed' into maint-0.3.2Nick Mathewson2017-10-31
|\ \ \ \ \
| * | | | | hs-v3: Attempt descriptor refetch when dirinfo changesDavid Goulet2017-10-31
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | When the directory information changes, callback to the HS client subsystem so it can check if any pending SOCKS connections are waiting for a descriptor. If yes, attempt a refetch for those. Fixes #23762 Signed-off-by: David Goulet <dgoulet@torproject.org>
| * | | | | hs-v3: Refactor client refetch functionDavid Goulet2017-10-04
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Create a function that tells us if we can fetch or not the descriptor for the given service key. No behavior change. Mostly moving code but with a slight change so the function can properly work by returning a boolean and also a possible fetch status code. Signed-off-by: David Goulet <dgoulet@torproject.org>
* | | | | | Merge branch 'maint-0.3.1' into maint-0.3.2Nick Mathewson2017-10-31
|\ \ \ \ \ \ | |_|_|/ / / |/| | | | |
| * | | | | Merge branch 'maint-0.3.0' into maint-0.3.1Nick Mathewson2017-10-31
| |\ \ \ \ \
| | * \ \ \ \ Merge branch 'maint-0.2.9' into maint-0.3.0Nick Mathewson2017-10-31
| | |\ \ \ \ \
| | | * \ \ \ \ Merge remote-tracking branch 'public/bug23693_029' into maint-0.2.9Nick Mathewson2017-10-31
| | | |\ \ \ \ \
| | | | * | | | | Make changes in server_mode() affect workers; fix a crash.Nick Mathewson2017-10-02
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Without this fix, changes from client to bridge don't trigger transition_affects_workers(), so we would never have actually initialized the cpuworkers. Fixes bug 23693. Bugfix on 3bcdb26267502e0 0.2.6.3-alpha, which fixed bug 14901 in the general case, but not on the case where public_server_mode() did not change.
* | | | | | | | | Merge remote-tracking branch 'public/bug23774_032' into maint-0.3.2Nick Mathewson2017-10-30
|\ \ \ \ \ \ \ \ \ | |_|_|_|_|_|/ / / |/| | | | | | | |
| * | | | | | | | Fix memory leak when freeing socket_table in KIST.Nick Mathewson2017-10-17
| | | | | | | | |
* | | | | | | | | bump to 0.3.2.3-alpha-dev.Nick Mathewson2017-10-27
| | | | | | | | |
* | | | | | | | | update to 0.3.2.3-alphaNick Mathewson2017-10-27
| | | | | | | | |
* | | | | | | | | hs-v3: Check the ed25519 key when picking intro pointDavid Goulet2017-10-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | If the intro point supports ed25519 link authentication, make sure we don't have a zeroed key which would lead to a failure to extend to it. We already check for an empty key if the intro point does not support it so this makes the check on the key more consistent and symmetric. Fixes #24002 Signed-off-by: David Goulet <dgoulet@torproject.org>
* | | | | | | | | fuzzing: Make hsdescv3 use the decoding API correctlyDavid Goulet2017-10-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Fixes #21509 Signed-off-by: David Goulet <dgoulet@torproject.org>
* | | | | | | | | Revert "Temporarily disable compilation of the v3 hs fuzzing code"David Goulet2017-10-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This reverts commit 5ef656e7d1b1e1e74c46bd02ce8faaa1d8d09403.
* | | | | | | | | fix check-changes warningNick Mathewson2017-10-26
| | | | | | | | |
* | | | | | | | | Add changes file for #23862.George Kadianakis2017-10-26
| | | | | | | | |
* | | | | | | | | Remove a duplicate call to update_microdesc_downloads()George Kadianakis2017-10-26
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | This call happens before we update our entry guards, so it needs to be removed for the fix to #23862 to work.
* | | | | | | | | Update entry guard state whenever we download a consensus.George Kadianakis2017-10-26
| |_|_|_|_|_|/ / |/| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Update guard state even if we don't have enough dirinfo since that actually affects the future download of dirinfos. Fixes #23862 on 0.3.0.1-alpha
* | | | | | | | hs-v2: Copy needed information between service on prunningDavid Goulet2017-10-25
| | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | | Turns out that when reloading a tor configured with hidden service(s), we weren't copying all the needed information between the old service object to the new one. For instance, the desc_is_dirty timestamp wasn't which could lead to the service uploading its desriptor much later than it would need to. The replaycache wasn't also moved over and some intro point information as well. Fixes #23790 Signed-off-by: David Goulet <dgoulet@torproject.org>
* | | | | | | | Merge branch 'maint-0.3.1' into maint-0.3.2Nick Mathewson2017-10-25
|\ \ \ \ \ \ \ \ | | |/ / / / / / | |/| | | | | | | | | | | | | | "ours" merge to avoid version bump
| * | | | | | | Merge branch 'maint-0.3.0' into maint-0.3.1Nick Mathewson2017-10-25
| |\ \ \ \ \ \ \ | | | |/ / / / / | | |/| | | | | | | | | | | | | "ours" merge to avoid version bump
| | * | | | | | Merge branch 'maint-0.2.9' into maint-0.3.0Nick Mathewson2017-10-25
| | |\ \ \ \ \ \ | | | | |/ / / / | | | |/| | | | | | | | | | | | "ours" merge to avoid version bump
| | | * | | | | Merge branch 'maint-0.2.8' into maint-0.2.9Nick Mathewson2017-10-25
| | | |\ \ \ \ \ | | | | | | | | | | | | | | | | | | | | | | | | | | | "ours" merge to avoid version bump