-
- Downloads
Move cell encryption/decription into the RelayCell class
"Less is more." Dave's pull request for ticket #27112 refactored our RelayCell into a BaseRelayCell and RawRelayCell class. Think I see what he's going for, and this was a step forward in some respects. But honestly added a lot of code and complexity without functionally doing anything new. Going with a hybrid of our approaches that integrates the part I think we agree on. Namely, simplifying our Circuit's send() method by moving cell encryption/decription down into the RelayCell class. This is a much, *MUCH* smaller diff than what Dave proposed. Happy to discuss integrating more of the pull request, but lets start with the part I think we agree on to give us a common point to work from.
No related branches found
No related tags found
Showing
- stem/client/__init__.py 24 additions, 41 deletionsstem/client/__init__.py
- stem/client/cell.py 104 additions, 7 deletionsstem/client/cell.py
- stem/client/datatype.py 13 additions, 5 deletionsstem/client/datatype.py
- stem/util/log.py 1 addition, 1 deletionstem/util/log.py
- stem/util/term.py 1 addition, 1 deletionstem/util/term.py
- test/unit/client/cell.py 1 addition, 0 deletionstest/unit/client/cell.py
- test/unit/client/size.py 1 addition, 0 deletionstest/unit/client/size.py
- test/unit/control/controller.py 0 additions, 1 deletiontest/unit/control/controller.py
Loading
Please register or sign in to comment