sched: Avoid adding the same channel twice to the KIST pending list

This is the quick fix that is keeping the channel in PENDING state so if we ever try to reschedule the same channel, it won't happened. Fixes #24700 Signed-off-by: David Goulet <dgoulet@torproject.org>

sched: Avoid adding the same channel twice to the KIST pending list
adaf3e9b · David Goulet · df312b3c · adaf3e9b · adaf3e9b
Commit adaf3e9b authored Jan 31, 2018 by David Goulet
--- a/changes/bug24700
+++ b/changes/bug24700
+  o Minor bugfixes (scheduler, KIST):
+    - Avoid adding the same channel twice in the KIST scheduler pending list
+      wasting CPU cycles at handling the same channel twice. Fixes bug 24700;
+      bugfix on 0.3.2.1-alpha.
--- a/src/or/scheduler_kist.c
+++ b/src/or/scheduler_kist.c
@@ -693,7 +693,6 @@ kist_scheduler_run(void)
       * after the scheduling loop is over. They can hopefully be taken care of
       * in the next scheduling round.
       */
-      chan->scheduler_state = SCHED_CHAN_WAITING_TO_WRITE;
      if (!to_readd) {
        to_readd = smartlist_new();
      }