Skip to content
  1. Mar 17, 2015
  2. Feb 03, 2015
  3. Feb 02, 2015
  4. Feb 01, 2015
  5. Jan 22, 2015
  6. Jan 19, 2015
  7. Jan 08, 2015
  8. Dec 28, 2014
  9. Sep 06, 2014
    • Isis Lovecruft's avatar
      6bc04ac2
    • Isis Lovecruft's avatar
      Disable obfs4 distribution (for now). · 519426c5
      Isis Lovecruft authored
      Until we have enough bridges supporting obfs4 to actually distribute
      them, and Tor Browser has obfs4 built in, I'm leaving the HTTPS dropdown
      item present but disabled, and nothing will be mentioned in emails sent
      by the Email Distributor until the `"obfs4"` line in
      `bridgedb.strings.CURRENT_TRANSPORTS is uncommented.
      519426c5
    • Isis Lovecruft's avatar
      Fix an additional four bugs in bridgdb.Bridges.parseExtraInfoFile(). · 514026ce
      Isis Lovecruft authored
      In addition to the one-character bug for #12932 which was fixed in
      commit 487c1b6c, there were an
      additional four bugs in the legacy parser,
      `bridgedb.Bridges.parseExtraInfoFile()` (which I am about to deprecate
      anyway for #9380):
      
             # get the transport line
             if ID and line.startswith("transport "):
                 fields = line[10:].split()
                 # [ arglist ] field, optional
                 if len(fields) >= 3:
                     arglist = fields[2:]               # BUGS 1 and 2
                     # parse arglist [k=v,...k=v] as argdict {k:v,...,k:v}
                     argdict = {}
                     for arg in arglist:
                         try: k,v = arg.split('=')      # BUG 3
                         except ValueError: continue    # BUG 4
                         argdict[k] = v
                         logging.debug("  Parsing Argument: %s: %s", k, v)
      
        BUG 1: This assumes the PT arguments are space-separated in the
               extrainfo descriptor. They are not; they are comma-separated.
      
        BUG 2: This would result in parsing the entire, comma-separated group
               of PT arguments into:
      
                   {"key1": "a,key2=b,key3=c"}
      
        BUG 3: This would produce a ValueError, because there's more than one
               '=' character. (Meaning that the whole set of arguments would
               be discarded due to Bug #4.)
      
        BUG 4: The whole set of arguments gets discarded, without even so much
               as a log message, if there was more than one argument.
      
      These are all bug fixes on a single commit,
      4300329a, from #4568. And I'm still
      deprecating the entire function anyway (for #9380) because the rest of
      it is likely just as full of bugs.
      
       * FIXES #12932 https://bugs.torproject.org/12932
      514026ce
    • Isis Lovecruft's avatar
    • Isis Lovecruft's avatar
      Add obfs4 to the HTTPS Distributor's PT options dropdown. · 1e2db4e7
      Isis Lovecruft authored
      This is temporary. It is needed in order to make sure that the
      regression tests for #12932 are functioning correctly. Because #12932 is
      about the way PT arguments are presented to the user in the bridge
      lines, to test the fixes for it, we must go through the UI (as the tests
      in `lib/bridgedb/test/test_https.py` do).
      1e2db4e7
  10. Sep 05, 2014
  11. Sep 03, 2014
  12. Aug 29, 2014
  13. Aug 28, 2014