The router_has_non_preferred_address() in its current implementation will
return true, regardless of whether IPv4 or IPv6 is preferred, if the
routerstatus_t has both type of addresses.

 * CHANGE router_has_non_preferred_address to be STATIC so we can test it.
 * ADD new unittest for router_has_non_preferred_address().

Clarify comments about DIRIND_ANONYMOUS and why we can
always use an IPv4 address.

If we are using begindir, we must have an ORPort.
So don't bother checking if we can fall back to a DirPort.

Fixes a bug in #17840 in tor 0.2.8.1-alpha.

After #17840 in 0.2.8.1-alpha, we incorrectly chose an IPv4
address for all DIRIND_ONEHOP directory connections,
even if the routerstatus didn't have an IPv4 address.

This likely affected bridge clients with IPv6 bridges.

Resolves #18921.

Variable rename only

This makes sure clients will only select relays which support
begindir over ORPort.

This improves client anonymity and avoids directory header tampering.
The extra load on the authorities should be offset by the fallback
directories feature.

This also simplifies the fixes to #18809.

teor (Tim Wilson-Brown) authored Apr 16, 2016 and Nick Mathewson committed Apr 26, 2016

As well as the existing reports of IPv6 address additions or removals,
the script now warns when keys change but IPv4:ORPort or
IPv6:IPv6ORPort remain the same.

Existing checks for other whitelist detail changes have also
been re-worded and upgraded to warnings.

This makes it easier for changes to be identified so operators can
be contacted to confirm whether the change is stable.

teor (Tim Wilson-Brown) authored Mar 31, 2016 and Nick Mathewson committed Apr 26, 2016

Also add misbehaving relays to updateFallbackDirs.py blacklist,
but leave them commented out in case it's a transient issue,
or it's been resolved by the download check fixes. (These
relays hang stem's downloader. It's unlikely they'll ever help
clients.)

Use IP address, effective family, and contact info to
discover and limit fallbacks to one per operator.

Also analyse netblock, ports, IP version, and Exit flag,
and print the results. Don't exclude any fallbacks from
the list because of netblocks, ports, IP version, or
Exit flag.

When creating the list of fallbacks for a release:
* don't output fallback name and contact
* sort fallbacks by fingerprint

But as advertised bandwidth is controlled by relays,
use consensus weight and median weight to bandwidth ratio
to approximate measured bandwidth.

Includes minor comment changes and parameter reordering.

Previously, we would cut the list down to 100 fallbacks,
then check if they could serve a consensus, and comment
them out if they couldn't.
This would leave us with fewer than 100 active fallbacks.

Now, we stop when there are 100 active fallbacks.

Also count fallbacks with identical contact info.
Also fix minor logging issues.

Give each fallback a set weight of 10.0 for client selection.

Fallbacks must have at least 3000 consensus weight.
This is (nominally) 100 times the expected extra load of
20 kilobytes per second (50 GB per month).

Fixes issue #17905.

Improve the download test:
* Allow IPv4 DirPort checks to be turned off.
* Add a timeout to stem's consensus download.
* Actually check for download errors, rather than ignoring them.
* Simplify the timeout and download error checking logic.

Tweak whitelist/blacklist checks to be more robust.
Improve logging, make it warn by default.

Cleanse fallback comments more thoroughly:
* non-printables (yes, ContactInfo can have these)
* // comments (don't rely on newlines to prevent // */ escapes)

Fixes bug 18716; bugfix on 0.2.1.1-alpha where memarea.c was
introduced.  Found by wbenny.

David Goulet authored Apr 05, 2016 and Nick Mathewson committed Apr 07, 2016

This changes simply renames them by removing "Testing" in front of them and
they do not require TestingTorNetwork to be enabled anymore.

Fixes #18481

Signed-off-by: David Goulet <dgoulet@ev0ke.net>

Yes, we could cast to unsigned char first, but it's probably safest
to just use our own (in test_util), or remove bad-idea features that
we don't use (in readpassphrase.c).

Fixes 18728.

Roger Dingledine authored Apr 05, 2016 and Nick Mathewson committed Apr 05, 2016

Stop blasting twelve lines per second from periodic_event_dispatch()
at loglevel debug.

Resolves ticket 18729; fix on 0.2.8.1-alpha.

Yawning Angel authored Apr 04, 2016 and Nick Mathewson committed Apr 05, 2016

Detect newer versions and fix our TLS code to use the new API.

Yawning Angel authored Apr 04, 2016 and Nick Mathewson committed Apr 05, 2016

It appears that setting the various callbacks is no longer required, so
don't.