* FIXES #25647: https://bugs.torproject.org/25647

 * ADD new script, scripts/coccinelle/cell_header_t.cocci, which
   transforms accesses to `{var_}cell_t` struct members which have
   been moved into `cell_header_t` to access through the `header`
   member.

 * ADD a note in scripts/README describing the added script.

 * CHANGE several files, as a result of running the cocci script on
   the codebase (with `spatch --sp-file
   scripts/coccinelle/cell_header_t.cocci --dir src/or --in-place`).

Alexander Hansen Færøy authored 6 years ago and David Goulet committed 6 years ago

See: https://bugs.torproject.org/25953

Signed-off-by: David Goulet <dgoulet@torproject.org>

Part of #25988

Signed-off-by: David Goulet <dgoulet@torproject.org>

Part of #25988

Signed-off-by: David Goulet <dgoulet@torproject.org>

No code behavior change.

Pars of #25988

Signed-off-by: David Goulet <dgoulet@torproject.org>

By doing so, it is renamed to voting_schedule_recalculate_timing(). This
required a lot of changes to include voting_schedule.h everywhere that this
function was used.

This effectively now makes voting_schedule.{c|h} not include dirauth/dirvote.h
for that symbol and thus no dependency on the dirauth module anymore.

Signed-off-by: David Goulet <dgoulet@torproject.org>

Rename them from dirvote_* to voting_schedule_*.

No code behavior change.

Part of #25988

Signed-off-by: David Goulet <dgoulet@torproject.org>

No code behavior change.

Part of #25988

Signed-off-by: David Goulet <dgoulet@torproject.org>

This function doesn't need to be public from the dirvote common file (which
will get renamed in future commit) so move it to dirauth/dirvote.c and make it
static.

Part of #25988

Signed-off-by: David Goulet <dgoulet@torproject.org>

It makes more sense to be in networkstatus.c so move it there and rename it
with the "networkstatus_" prefix.

Part of #25988

Signed-off-by: David Goulet <dgoulet@torproject.org>

Closes ticket25937.

This is remarkably simple, given the macros in the last commit.

This change should have no behavioral effect: it just uses macros to
describe the current control flow.

Apparently, we can decide our state is dirty before we create the
event to tell the mainloop that we should save it.  That's not a
problem, except for the assertion failure.

Commit 0f3b765b added
tor_assert_nonfatal_unreached() to dirvote_add_vote() and
dirvote_add_signatures() when the dirauth module is disabled.

However, they need to return a value. Furthermore, the dirvote_add_vote()
needs to set the msg_out and status_out so it can be sent back. Else,
uninitialized values would be used.

Signed-off-by: David Goulet <dgoulet@torproject.org>

Originally, it was made public outside of the dirauth module but it is no
longer needed. In doing so, we put it back in dirvote.c and reverted its name
to the original one:

dirvote_authority_cert_dup() --> authority_cert_dup()

Signed-off-by: David Goulet <dgoulet@torproject.org>

The --disable-module-* configure option removes code from the final binary but
we still build the unit tests with the disable module(s) so we can actually
test that code path all the time and not forget about it.

Signed-off-by: David Goulet <dgoulet@torproject.org>

This code is only for dirauth so this commit moves it into the module in
dirvote.c.

No code behavior change.

Signed-off-by: David Goulet <dgoulet@torproject.org>

Both functions are used for directory request but they can only be used if the
running tor instance is a directory authority.

For this reason, make those symbols visible but hard assert() if they are
called when the module is disabled. This would mean we failed to safeguard the
entry point into the module.

Signed-off-by: David Goulet <dgoulet@torproject.org>

In order to further isolate the dirauth code into its module, this moves the
handling of the directory request GET /tor/status-vote/* into the module.

Signed-off-by: David Goulet <dgoulet@torproject.org>

In order to make sr_commit_free() only used by the dirauth module, this
commits moves the commits free from a vote object into the dirvote.c file
which is now only for the module.

The function does nothing if the module is disabled.

Signed-off-by: David Goulet <dgoulet@torproject.org>