John Brooks authored 9 years ago and John Brooks committed 8 years ago

Tor stores client authorization cookies in two slightly different forms.
The service's client_keys file has the standard base64-encoded cookie,
including two chars of padding. The hostname file and the client remove
the two padding chars, and store an auth type flag in the unused bits.

The distinction makes no sense. Refactor all decoding to use the same
function, which will accept either form, and use a helper function for
encoding the truncated format.

John Brooks authored 9 years ago and John Brooks committed 8 years ago

This is needed by control.c.

Also, check whether client_name is set before doing memwipe.

Sebastian Hahn authored 9 years ago and Nick Mathewson committed 9 years ago

This includes a small refactoring to use a new enum (workqueue_reply_t)
for the return values instead of just ints.

This avoids a conflict with a macro decl from libevent 1.x.

Fixes bug 16867; bug not in any released Tor.

We don't want to accept any work after one of our worker functions has
returned WQ_RPL_SHUTDOWN. This testcase currently fails, because we do
not actually stop any of the worker threads.

Needs changes file, documentation, test integration, more tests.